Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-6107] Replaced SearchDateRange component with SearchDateRangeAdvanced Component #9023

Merged
merged 25 commits into from
Dec 6, 2023
Merged

[ACS-6107] Replaced SearchDateRange component with SearchDateRangeAdvanced Component #9023

merged 25 commits into from
Dec 6, 2023

Conversation

swapnil-verma-gl
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
Removed the older, unused SearchDateRange component. SearchDateRangeAdvanced is now renamed to SearchDateRange

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@swapnil-verma-gl swapnil-verma-gl force-pushed the dev-swapnil-acs-6107-remove-date-range branch from b62acab to b4e5fa5 Compare October 25, 2023 12:05
@swapnil-verma-gl swapnil-verma-gl marked this pull request as ready for review October 25, 2023 12:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@swapnil-verma-gl
[ACS-6107] Removed date range component from ADF content-services
47e9499
@swapnil-verma-gl
[ACS-6107] Removed references of date range component in code
258c5da
@swapnil-verma-gl
[ACS-6107] Updated documentation to replace occurrences of date range…
c157c63 
… component with date-range-advanced-tabbed component
@swapnil-verma-gl
[ACS-6107] Renamed DateRangeAdvanced to DateRange. Renamed DateRangeA…
2415564 
…dvancedTabbed to DateRangeTabbed
@swapnil-verma-gl
[ACS-6107] Fixed missing export of SearchDateRangeTabbedComponent
2607b76
@swapnil-verma-gl
[ACS-6107] Replaced occurrences of date-range-advanced with date-rang…
39ceb19 
…e in HTML and Unit Tests automation ids
@swapnil-verma-gl
[ACS-6107] Documentation corrections
1f8c1fb
@swapnil-verma-gl
[ACS-6107] Reverted unneeded documentation formatting
fbdc715
@swapnil-verma-gl
[ACS-6107] Reverted unneeded documentation formatting
f878735
@swapnil-verma-gl
[ACS-6107] Reverted unneeded documentation formatting
7f1edb4
@swapnil-verma-gl
[ACS-6107] Migrated unneeded E2E test case to unit test
eb2c920
@swapnil-verma-gl
[ACS-6107] Removed search-date-range E2E
9f390df
@swapnil-verma-gl
[ACS-6107] Resolved PR comments. Removed date-range-filter.page.ts. R…
0e4a00e 
…emoved unused translation keys. Updated documentation to refer proper comment name
@swapnil-verma-gl
[ACS-6107] Updated documentation for SearchDateRange component to men…
3f9f08a 
…tion the change from original configuration to the newer configuration
@swapnil-verma-gl
[ACS-6107] Corrected wrong version in documentation
cbbaa3f
@swapnil-verma-gl swapnil-verma-gl force-pushed the dev-swapnil-acs-6107-remove-date-range branch from 33ecb81 to cbbaa3f Compare December 5, 2023 07:29
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@swapnil-verma-gl swapnil-verma-gl merged commit f47fb2a into develop Dec 6, 2023
34 checks passed
@swapnil-verma-gl swapnil-verma-gl deleted the dev-swapnil-acs-6107-remove-date-range branch December 6, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@MichalKinas MichalKinas MichalKinas approved these changes

@nikita-web-ua nikita-web-ua Awaiting requested review from nikita-web-ua

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@swapnil-verma-gl @MichalKinas @AleksanderSklorz @DenysVuika @tomgny